bandwidth control & pcq

I want to have my users sharing the available bandwidth to the internet so that no one user can stop all the other users from using the network when one user is downloading a file. I also want to prioritize the traffic as shown (icmp, voip, http, other, p2p).

I have the following config:

 6   name="download" parent=global-in packet-mark="" limit-at=0 
     queue=pcq_download priority=8 max-limit=1500000 burst-limit=0 
     burst-threshold=0 burst-time=0s 
 
 7   name="1d_ping" parent=download packet-mark=ping limit-at=0 
     queue=pcq_download priority=1 max-limit=0 burst-limit=0 
     burst-threshold=0 burst-time=0s 
 
 8   name="2d_voip" parent=download packet-mark=voip limit-at=0 
     queue=pcq_download priority=2 max-limit=0 burst-limit=0 
     burst-threshold=0 burst-time=0s 
 
 9   name="3d_http" parent=download packet-mark=http limit-at=0 
     queue=pcq_download priority=3 max-limit=0 burst-limit=0 
     burst-threshold=0 burst-time=0s 
 
10   name="4d_other" parent=download packet-mark=other limit-at=0 
     queue=pcq_download priority=4 max-limit=0 burst-limit=0 
     burst-threshold=0 burst-time=0s 
 
11   name="8d_p2p" parent=download packet-mark=p2p limit-at=64000 
     queue=pcq_download priority=8 max-limit=256000 burst-limit=0 
     burst-threshold=0 burst-time=0s 
 
12   name="upload" parent=global-out packet-mark="" limit-at=0 queue=pcq_uploa>
     priority=8 max-limit=1500000 burst-limit=0 burst-threshold=0 
     burst-time=0s 
 
13   name="1u_ping" parent=upload packet-mark=ping limit-at=0 queue=pcq_upload 
     priority=1 max-limit=0 burst-limit=0 burst-threshold=0 burst-time=0s 
 
14   name="2u_voip" parent=upload packet-mark=voip limit-at=0 queue=pcq_upload 
     priority=2 max-limit=0 burst-limit=0 burst-threshold=0 burst-time=0s 
 
15   name="3u_http" parent=upload packet-mark=http limit-at=0 queue=pcq_upload 
     priority=3 max-limit=0 burst-limit=0 burst-threshold=0 burst-time=0s 
 
16   name="4u_other" parent=upload packet-mark=other limit-at=0 
     queue=pcq_upload priority=4 max-limit=0 burst-limit=0 burst-threshold=0 
     burst-time=0s 
 
17   name="8u_p2p" parent=upload packet-mark=p2p limit-at=64000 
     queue=pcq_upload priority=8 max-limit=256000 burst-limit=0 
     burst-threshold=0 burst-time=0s

This doesnt seem to be doing much to help, and in fact it makes my voip sound like total crap. What am I doing wrong here?

Thanks for any help!

Set you max to 80% of your actual pipe size and see if it helps

other than that does everything look correct?

Is there a reason you have icmp before voip?

it reduces ping time, think, thats all.

and it does not really reduce VoIP performance

yep, i put that first so i could see it it actually makes any difference with the rules, but I cant really tell the difference between it and not having it.

yes

what is ‘yes’ a reply to?

Variable,

Did you try doing what Equis said? By settings the max-limit?