how do it in perl API

RouterOS Scripting
1 
#!/bin/bash
IP=`mysql -h127.0.0.1 -u root -psomepass billing -e "SELECT ip from users where state = 'on' "`
for i in ${IP[*]} ; do
 echo $i
ssh -l admin -i /root/.ssh/id_dsa 15.13.130.194 "/ip firewall address-list add address=$i list=access"
done

can you help me?
because in bash, script work very very slowly

2

I don’t know about the Perl API, but you could improve performance of that bash script if you don’t spawn a new ssh session for every single command but instead collect commands into a file piped into one ssh session.

#!/bin/bash
TEMPFILE="/tmp/$(basename $0).$$.tmp"
IP=`mysql -h127.0.0.1 -u root -psomepass billing -e "SELECT ip from users where state = 'on' "`
for i in ${IP[*]} ; do
  echo "/ip firewall address-list add address=$i list=access" >> $TEMPFILE
done
ssh -l admin -i /root/.ssh/id_dsa 15.13.130.194 < $TEMPFILE
rm $TEMPFILE

Not elegant either, but probably a lot faster.

Also: http://forum.mikrotik.com/t/perl-api-client/19990/1 ← Perl API

3

thanks, i saw that topic early

if i used this script, then i see

Pseudo-terminal will not be allocated because stdin is not a terminal.
4

Yes, that’s normal. You’re redirecting stdin for the ssh session to take input from a file instead of a terminal, so it informs you that it’s not going to allocate a pseudo terminal for the session because it would be pointless to do so. It’ll still execute all the commands in the file.

5

yes-yes
i understand this :slight_smile:
+