Ping Speed PHP Pear API

[patrickclover]

Im trying to use this method again for another use case but am having an issue… i seem to be getting this Call to a member function getType() on a non-object. Could you lend a hand? could it be something to do with the memory buffer?

@boen_robot

You’d need to use $client->sendAsync(), and then cancel the command once you’re ready.

To use a “duration” in the sense of “time”, you can use $client->loop($timeout), but keep in mind that all gathered replies are buffered in the server’s memory until you later read them. You can specify the “interval” argument on “ping-speed” in order to make sure you don’t get more than “interval times timeout” replies.

e.g.

//interval * timeout = ~8 replies
$client->sendAsync(new RouterOS\Request('/tool ping-speed address=192.168.88.100 interval=0.5', null, 'p'));
//Gather everything for 4 seconds
$client->loop(4);
//Cancel the request afterwards... Note that the replies will feature one last !trap due to the cancel, and !done reply
$client->cancelRequest('p');

//Get all data replies for the request
$responses = $client->extractNewResponses('p')->getAllOfType(RouterOS\Response::TYPE_DATA);

//In the case of ping-speed, you probably want the average speed at the end, so...
$avg = $responses->end()->getArgument('average');

//Otherwise, process $responses as you see fit

To use a “duration” in the sense of “number of replies” or some other more artificial factor, you can use a callback inside sendAsync(), and make it return true when you’re ready to cancel. The callback is invoked for each reply and is not buffered, so you can stop processing at any time, as long as you keep track of how long you’ve been calling the callback. Similarly to before, if using interval, you can artificially limit the time if you keep track of the count or vice-versa.

e.g.

$avg = '';
$count = 0;
$client->sendAsync(
    new RouterOS\Request('/tool ping-speed address=192.168.88.100 interval=0.5', null, 'p'),
    function ($response) use (&$count, &$avg) {
        if ($response->getType() === RouterOS\Response::TYPE_DATA) {
            $avg = $response->getArgument('average');

            return 100 === ++$count;
        }
    }
);
$client->completeRequest('p');

[boen_robot]

I’m assuming you’re talking about the second quoted code (since the first contains no calls to getType())?

In the latest version, Response::getArgument() was renamed to Response::getProperty(). You can make a cross-version compatible code by not using a name… That one is probably not your particular issue though…

Try to add

var_dump($response); 

in the function, and see what’s there, i.e.

$client->sendAsync(
    new RouterOS\Request('/tool ping-speed address=192.168.88.100 interval=0.5', null, 'p'),
    function ($response) use (&$count, &$avg) {
        var_dump($response);
        if ($response->getType() === RouterOS\Response::TYPE_DATA) {
            $avg = $response('average');

            return 100 === ++$count;
        }
    }
); 

It should be an object of type PEAR2\Net\RouterOS\Response…

Also, make sure the variable name is the same (copy&paste the one on the “function” line to the “getType()” line; just in case).

[patrickclover]

Ahh this does work but then I can’t return on it because php doesn’t work asynchronously, is there a work around for this callback?

@boen_robot

I’m assuming you’re talking about the second quoted code (since the first contains no calls to getType())?

In the latest version, Response::getArgument() was renamed to Response::getProperty(). You can make a cross-version compatible code by not using a name… That one is probably not your particular issue though…

Try to add

var_dump($response);

in the function, and see what’s there, i.e.

$client->sendAsync(
    new RouterOS\Request('/tool ping-speed address=192.168.88.100 interval=0.5', null, 'p'),
    function ($response) use (&$count, &$avg) {
        var_dump($response);
        if ($response->getType() === RouterOS\Response::TYPE_DATA) {
            $avg = $response('average');

            return 100 === ++$count;
        }
    }
);

It should be an object of type PEAR2\Net\RouterOS\Response…

Also, make sure the variable name is the same (copy&paste the one on the “function” line to the “getType()” line; just in case).

[boen_robot]

What do you mean by “return on it”?

If you mean stopping execution of the callback at a point, then you can, by returning true from within the callback. The callback will then be executed only 2 times more - once with an error reply, and once more with a last reply (signaling there’s not going to be anything more).

If you mean returning a value from inside the callback to the outside, that’s what the “use” part after the function is. You add a variable by reference, and then any modifications inside the function will be available from the outside too.


But yes, PHP doesn’t work asynchronously. For a workaround, you’d need to install the pthreads extension, and invoke a thread for each whatever. The API client is not thread safe though, so if you’re using the same connection in multiple threads, you’d need to lock() and wait() accordingly.