I've setup a PPPoE client to a ADSL to ethernet modem on ethernet1, it says connected

no internet , but ping tool pings external address via PPPoE account but not Ethernet1 , is there a link/NAT/Route need to link PPPoE to Ethernet1

Typically if you are using (say) Ether 1 for the WAN/ADSL Modem etc. then your LAN would be on another interface (e.g. Ether 2). For accessing the internet the LAN traffic would use a default route via the PPPoE Client interface and you would masquerade traffic leaving on the PPPoE Client interface.

thanks will look into that too

Ethernet1 is for ADSL modem ( Draytek Vigor120 )
Ethernet4 is LAN ( 192.168.1.1 )

Tried that, changed "Out. Interface" from "Ether1" to "673194" ( PPPoE name ) which is using Chain = srcnat Action = masquerade

still no luck ,

It is easier to help if you upload your config. Run /export compact file=filename then drag the file from the Files tab.

Sorted ,