/ip dhcp-server lease {
:foreach i in=[find (!dynamic && status="bound")] do={
:local activeAddress [get $i active-address]
:local activeMacAddress [get $i active-mac-address]
:local hostname [get $i host-name]

:put ($outputContent . "\n" . $activeAddress . "," . $activeMacAddress . "," . $hostname)
}
}

sshpass -p $pass ssh -o $log -n $user@$h -p 4111 /ip dhcp-server lease { :foreach i in=[find (!dynamic && status="bound")] do={ :local activeAddress [get $i active-address]; :local activeMacAddress [get $i active-mac-address]; :local hostname [get $i host-name]; :put ($outputContent . "\n" . $activeAddress . "," . $activeMacAddress . "," . $hostname) } } print file=$n

Try to place the whole command for Mikrotik into quotes....

N=4; echo "$N"

N=4; echo '$N'

$N

That looks to me as an insufficient indication to bash what it should handle and what not..

Try to place the whole command for Mikrotik into quotes and escape the symbols ",$,\ you need to make it to Mikrotik:

sshpass -p $pass ssh -o $log -n $user@$h -p 4111 "/ip dhcp-server lease { :foreach i in=[find (!dynamic && status=\"bound\")] do={ :local activeAddress [get \$i active-address]; :local activeMacAddress [get \$i active-mac-address]; :local hostname [get \$i host-name]; :put (\$outputContent . \"\\n\" . \$activeAddress . \",\" . \$activeMacAddress . \",\" . \$hostname) } } print file=\$n"

Hint: to make sure it works properly, start by using echo instead of sshpass ... -p 4111 and fine-tune the escaping until the output is exactly what you want the Mikrotik to get.

Sorry, can you use another wording? It is not clear to me what you need.

Because a dash was missing in what I wrote. Now I got home and tried using the Tab button:

Code: Select all

[me@MyTik] > put [ip dhcp-server lease get [find host-name=my-HP] address]
192.168.88.254

sshpass -p $pass ssh -o $log -n $user@$h -p 4111:global n [ip dhcp-server lease get [find host-name=PC] address];

ip dhcp-server lease print file=$n

:global n [ip dhcp-server lease get [find host-name=PC] address];/file print file=$n

Code: Select all

:global n [ip dhcp-server lease get [find host-name=PC] address];/file print file=$n

Code: Select all

:global n [ip dhcp-server lease get [find host-name=PC] address];/file print file=$n

This line of code says:
- set the value of a global-scoped variable named n to the ip address leased to device with hostname PC
- print the list of existing files into a file whose name is retrieved from the global variable n
So you end up with a file named ip.add.re.ss.txt. which contains a list of all files currently available on the machine. On my machine it gives no errors if entered directly, so if it causes trouble via ssh, you either haven't used single quotes as Metod has recommended or there is some other error.

/file print is equivalent to ls / in linux; /file print file=something is equivalent to ls / > something

ip dhcp-server lease print file=$n

ip dhcp-server lease get [find host-name=pc] address

ip dhcp-server lease print file=$n

If you really do want the file name to be sourced from variable n as you suggest, you have to do what I wrote earlier.

There is no file modifier to put, nor there is a way to make print print a single value.

So you have to generate a file with any bogus contents:
/routing print file=$n
and then replace the bogus contents with the one you want:
/file set ($n.".txt") contents=[/ip dhcp-server lease get [find host-name=kladionica] address]

Radiš previše stvari istovremeno i teško je da sa orijentiram što je u stvari problematično.

If you're going to fetch lease info from linux box via ssh, then you can easily do filtering with some simple commands on linux box itself.

One-liner that does the trick:

Code: Select all

WANTED=my-host-name; LEASES=$( ssh user@routerboard.my.domain '/ip dhcp-server lease { :foreach i in=[find (!dynamic && status="bound")] do={ :local activeAddress [get $i active-address]; :local activeMacAddress [get $i active-mac-address]; :local hostname [get $i host-name]; :put ($outputContent . "\n" . $activeAddress . "," . $activeMacAddress . "," . $hostname) } }' ) ; echo ${LEASES} | grep ${WANTED} | cut -d, -f1

or, to make a script that takes hostname as argument:

Code: Select all

#!/usr/bin/env bash
WANTED=$1
if [ -z "${WANTED}" ]; then
    echo 'Error! You have to specify host name as single argument.' >&2
    exit 1
fi
RB=user@routerboard.my.domain
LEASES=$( ssh ${RB} '/ip dhcp-server lease { :foreach i in=[find (!dynamic && status="bound")] do={ :local activeAddress [get $i active-address]; :local activeMacAddress [get $i active-mac-address]; :local hostname [get $i host-name]; :put ($outputContent . "\n" . $activeAddress . "," . $activeMacAddress . "," . $hostname) } }' )
echo ${LEASES} | grep ${WANTED} | cut -d, -f1

save it as a file and then run it, giving it host name, for which you want to get IP address from lease. Adjust whatever is assigned to variable RB, to correct value for your case (user might be admin, host name might be IP address if your RB doesn't have FQDN available from your DNS service.
If you want to fetch leased IP address for more than one host, you can replace the last line with a loop, looping through host names of interest. No need for multiple ssh lease fetches.

#!/bin/bash
user=admin
read -sp 'Password ' pass
log=StrictHostKeyChecking=no
locdir=/root/testbash/mikrotik/dhcp_lease
rm -rf /root/.ssh/known_hosts
d=$(date '+%d-%b-%Y')
mkdir $locdir/Company_$d
cd $locdir/Company_$d
while read n h;do
sshpass -p $pass ssh -o $log -n $user@$h -p 4111 ip dhcp-server lease print file=$n
sshpass -p $pass sftp -oStrictHostKeyChecking=no -oPort=4111 $user@$h:$n.txt
sshpass -p $pass ssh -o $log -n $user@$h -p 4111 file remove $n.txt
done < $locdir/hosts.txt

Because a dash was missing in what I wrote. Now I got home and tried using the Tab button:

Code: Select all

[me@MyTik] > put [ip dhcp-server lease get [find host-name=my-HP] address]
192.168.88.254

invalid internal item number

1. you can take whole output from your script (I don't know how exactly does it look like, are data fields comma-separated within single line or what) and filter only columns you need from that output. But form what I understand you over complicate the process of getting the lease data from routerboard ...
2. you can adjust your script so that only IP address is output from the script itself. You can achieve that by filtering results from individual sshpass calls ...

LEASE_IP=$( sshpass -p $pass ssh -o $log -n $user@$h -p 4111 ''/ip dhcp-server lease { :foreach i in=[find (!dynamic && status="bound")] do={ :local activeAddress [get $i active-address]; :local activeMacAddress [get $i active-mac-address]; :local hostname [get $i host-name]; :put ($outputContent . "\n" . $activeAddress . "," . $activeMacAddress . "," . $hostname) } }' | grep $h | cut -d, -f1 )

I'm not familiar with sshpass but judging from the on-line documentation it will return stdout from remote process just like ssh does.

You have two possibilities:

1. you can take whole output from your script (I don't know how exactly does it look like, are data fields comma-separated within single line or what) and filter only columns you need from that output. But form what I understand you over complicate the process of getting the lease data from routerboard ...
2. you can adjust your script so that only IP address is output from the script itself. You can achieve that by filtering results from individual sshpass calls ...

My guess is that you can use sshpass in your script in the following manner:

Code: Select all

LEASE_IP=$( sshpass -p $pass ssh -o $log -n $user@$h -p 4111 ''/ip dhcp-server lease { :foreach i in=[find (!dynamic && status="bound")] do={ :local activeAddress [get $i active-address]; :local activeMacAddress [get $i active-mac-address]; :local hostname [get $i host-name]; :put ($outputContent . "\n" . $activeAddress . "," . $activeMacAddress . "," . $hostname) } }' | grep $h | cut -d, -f1 )

IP address of host name $h should be now in variable LEASE_IP and you can do with it whatever you want. Stick it into the while loop instead of three calls to sshpass you currently have.
If you have many hosts in DHCP lease list with similar names, the simple "grep" above might return false positives ... in that case you may want to tinker with it so that it will only return single result (the wanted one).

I would really avoid fancy filtering to be done on ROS as Linux host offers many powerful tools to do it and you're using linux anyway. The cost of filtering on linux is more data transferred out of ROS, but I guess this should not be deciding factor unless you have many thousand leases on every RB device you're polling.

#!/bin/bash
user=admin
read -sp 'Password ' pass
log=StrictHostKeyChecking=no
locdir=/etc/ansible/
rm -rf /root/.ssh/known_hosts
d=$(date '+%d-%b-%Y')
mkdir $locdir/Company_$d
cd $locdir/Company_$d
while read n h;do
LEASE_IP=$( sshpass -p $pass ssh -o $log -n $user@$h -p 4111 ''/ip dhcp-server lease { :foreach i in=[find (!dynamic && status="bound")] do={ :local activeAddress [get $i active-address]; :local activeMacAddress [get $i active-mac-addre$
#sshpass -p $pass ssh -o $log -n $user@$h -p 4111 ip dhcp-server lease print file=$n
#sshpass -p $pass sftp -oStrictHostKeyChecking=no -oPort=4111 $user@$h:$n.txt
#sshpass -p $pass ssh -o $log -n $user@$h -p 4111 file remove $n.txt
done < $locdir/hosts11.txt

command substitution: line 12: syntax error near unexpected token `('

I found strange, this is my code now

Code: Select all

LEASE_IP=$( sshpass -p $pass ssh -o $log -n $user@$h -p 4111 ''/ip dhcp-server lease { :foreach i in=[find (!dynamic && status="bound")] do={ :local activeAddress [get $i active-address]; :local activeMacAddress [get $i active-mac-address]; :local hostname [get $i host-name]; :put ($outputContent . "\n" . $activeAddress . "," . $activeMacAddress . "," . $hostname) } }' | grep $h | cut -d, -f1 )