/ip firewall address-list> :foreach a in=[find where list=blacklist dynamic] do={:put [:resolve [/ip firewall address-list get $a address]] }
1 name="safe-resolve" owner="admin" policy=read,write,test last-started=sep/03/2011 18:29:22 run-count=99 source=
:global inAddr;
:global outAddr "";
:set outAddr [:resolve $inAddr];
2 name="blacklist-names" owner="admin" policy=read,write,test last-started=sep/03/2011 18:29:20 run-count=12 source=
:global inAddr;
:global outAddr;
:foreach addr in=[/ip firewall address-list find where list=blacklist dynamic] do={
set inAddr [/ip firewall address-list get $addr address];
/system script run safe-resolve;
:if ($outAddr != "") do={
:put $outAddr;
}
}
[admin@MikroTik] /system script> run blacklist-names;
pool-109-191-246-40.is74.ru
87-126-71-139.btc-net.bg
57.88.178.61.dail.lz.gs.dynamic.163data.com.cn
dynamicip-46-0-145-205.pppoe.samara.ertelecom.ru
mx-ll-180.183.141-17.dynamic.3bb.co.th
ip136.hichina.com
failure: dns name does not exist
1 name="safe-resolve" owner="admin" policy=read,write,test last-started=sep/03/2011 18:29:22 run-count=99 source=
:global done
:global inAddr
:global outAddr ""
:set outAddr [:resolve $inAddr]
:set done true
2 name="blacklist-names" owner="admin" policy=read,write,test last-started=sep/03/2011 18:29:20 run-count=12 source=
:global done
:global inAddr
:global outAddr
:foreach addr in=[/ip firewall address-list find where list=blacklist dynamic] do={
:set inAddr [/ip firewall address-list get $addr address]
:set done false
:execute safe-resolve
:while(!$done) do={:nothing}
:if ($outAddr != "") do={
:put $outAddr
}
}:local loopCount
:local loopError
:set done false
:execute myScript
:set loopCount 0
:set loopError false
:while(!$done) do={
:set loopCount $loopCount + 1
if($loopCount > 11) do={
:set done true
:set loopError true
}
}Running RouterOS 5.6.what ROS version you are using?
:put [:resolve <ip-address-here>]Yeah, mostly just grumbling about the gaps in the documentation, which can be very frustrating.I am aware that the ":execute" command is not documented, but it should be. It works really well. I've been using it since the V2.9.x era.
Yeah, understood that, it was how to limit the loop and whether to use ":delay" or just ":nothing". (Which BTW, is also missing from the scripting docs...) The original loop would have waited forever when a lookup failure occurred.The synchronization is handled by the "done" variable. That is the "while not done, do nothing" loop. But you will need to add a loop count to that to break from the loop after a dozen or so iterations.
:global done
:set done false
:call myScript
:if(!$done) do={
// now you know it did not finish, but aborted.
// so do what you do on a fail
}:global done
// do the stuff that might abort here
// If it aborts, that is the same as "return false"
// then last thing (equivalent of "return true")
:set done true:global return
:set return false
:global num
:put (" try to resolve #".$num)
/resolve [/ip firewall address-list get $num comment]
:set return true:global num
:local i
:local x 2
:for i from=0 to=$x step 1 do={
:set num $i
:put ("checking ".$num)
/sys script run [find name="catch_script"];
:if ($return) do={
:put ($num."= risolto");
} else={
:put ($num."= non risolto");
}
} checking 0
try to resolve #0
0= risolto
checking 1
try to resolve #1
1= risolto
checking 2
try to resolve #2
failure: dns name does not exist
[admin@Morm1] /system script>
:do {
:put [:resolve www.example.com];
} on-error={ :put "resolver failed"};
:put "lala"
output:
resolver failed
lala
export file=foo.barYes, an error will exit before the next line. If you don't want that, then you need the ":do { /badcommand} on-error={};" syntax shown above around code that might cause an error (and where you'd still want rest of code to continue).Does exiting on first error hold true for ssh executed scripts as well?
