Hi, my ISP needs VLAN to get PPOE session connected.
I actually did that with:
PPOE connects instantly, but the problem is I can't get internet to work.
Do I have to untag or what am I missing?

Thank you

Have you added a NAT rule for LAN-to-Internet traffic? For recent versions of RouterOS it is simply a case of changing the WAN interface list - likely from ether1 (the usual default) to PPPoE_Out in this case.

Attach the vlan to the PPoE-Out interface not the sfp1 physical interface as you have done looking at your snippet (GOOD)

For interface list
vlan20 interface list=WAN
PPoE-Out list=WAN
sfp1 list=WAN

(all three just to be on the safe side).

if that doesnt fix it, need to see the rest of the code
./export hide-sensitive file=anynameyouwish