RB upgrade script issues

Nutcracker · Thu Jun 21, 2018 3:14 pm

Hi all

Below is the script and scheduler items that I am busy testing out.
Problem is that it seems to work sometimes, but when I leave it to run on it's own at 05:00, it doesn't complete and simply loops.

Am I missing a semi-colon or something?
Any assistance would be appreciated.

Code: Select all

/system scheduler

add interval=1d name=upgrade on-event=rb_upgrade policy=\

    ftp,reboot,read,write,policy,test,password,sniff,sensitive start-date=\

    jun/16/2018 start-time=05:00:00

add name=startup_upgrade on-event=rb_upgrade policy=\

    ftp,reboot,read,write,policy,test,password,sniff,sensitive start-time=\

    startup

/system script

add name=rb_upgrade owner=firstline policy=\

    ftp,reboot,read,write,policy,test,password,sniff,sensitive source=":log info\

    \_\"Checking for RouterOS upgrades\";\r\

    \n/system package update install\r\

    \n:log info \"Checked for RouterOS upgrades\";\r\

    \n:log info \"Checking firmware...\";\r\

    \n/system routerboard\r\

    \n:if ([get current-firmware] != [get upgrade-firmware]) do={\r\

    \n     :log info \"Updating firmware\";\r\

    \n     upgrade;\r\

    \n     #  Automatic restart\r\

    \n     :delay 2s\r\

    \n     /system reboot\r\

    \n     } else={\r\

    \n     :log info \"No update.\"\r\

    \n     }\r\

    \n"

Nutcracker · Fri Jun 22, 2018 8:22 am

Some more info this morning:

Code: Select all


05:00:00 script,info Checking for RouterOS upgrades 

05:00:00 script,info Checked for RouterOS upgrades 

05:00:00 script,info Checking firmware... 

05:00:00 script,info No update.

This is what I am getting on most router's this morning, yet they are not upgrading to 6.42.4(they are on 6.42.3).

Once again I ask, am I doing something wrong?
If you guys need any additional info, please let me know.

dasiu · Fri Jun 22, 2018 11:06 am

I'd add some debugging info:

/system scheduler
add interval=1d name=upgrade on-event=rb_upgrade policy=ftp,reboot,read,write,policy,test,password,sniff,sensitive start-date=jun/16/2018 start-time=05:00:00
add name=startup_upgrade on-event=rb_upgrade policy=ftp,reboot,read,write,policy,test,password,sniff,sensitive start-time=startup
/system script
add name=rb_upgrade owner=firstline policy=ftp,reboot,read,write,policy,test,password,sniff,sensitive source=":log info \"Checking for RouterOS upgrades\";\r\
\n/system package update install\r\
\n:log info \"Checked for RouterOS upgrades\";\r\
\n:log info \"Checking firmware...\";\r\
\n/system routerboard\r\
\n:local oldfw [get current-firmware]\r\
\n:local newfw [get upgrade-firmware]\r\
\n:if (\$oldfw != \$newfw) do={\r\
\n :log info \"Updating firmware from \$oldfw to \$newfw\";\r\
\n upgrade;\r\
\n # Automatic restart\r\
\n :delay 2s\r\
\n /system reboot\r\
\n } else={\r\
\n :log info \"No update. Current version is \$oldfw, upgrade version is also \$newfw.\"\r\
\n }\r\
\n"

rosman · Tue Nov 02, 2021 12:40 am

Did you ever figure this out? I'd like to know the answer.

Rich

Jotne · Tue Nov 02, 2021 10:45 am

Script looks fine, only removed not needed ; at end of lines.

:log info "Checking for RouterOS upgrades"
/system package update install
:log info "Checked for RouterOS upgrades"
:log info "Checking firmware..."
/system routerboard
:if ([get current-firmware] != [get upgrade-firmware]) do={
:log info "Updating firmware"
	upgrade
	# Automatic restart
	:delay 2s
	/system reboot
} else={
	:log info "No update."
}

BUT, I would never ever add a script like this and schedule it.
Why? You need to test this upgrade on an local non production router to see if router works or get bricked after upgrade.
You can in the script make a test to a web page, that has yes or no as a result. If its set to yes, it will allow upgrade of the router.
PS you need to test each an every type of MT device before you allow upgrade.

Example
Running 7.1rc5 on a router and you try /system package update install, it will downgrade it to 6.49....

RB upgrade script issues

RB upgrade script issues

Re: RB upgrade script issues

Re: RB upgrade script issues

Re: RB upgrade script issues

Re: RB upgrade script issues

Who is online